Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding all the properties tests #1038

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

magdyheiba
Copy link
Contributor

Adding All properties tests including the performance
Fix the performance property initialization issue

let's hope for more than 50% coverage 🔢

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #1038 (565c405) into main (f8623f9) will increase coverage by 16.34%.
The diff coverage is 42.65%.

@@              Coverage Diff              @@
##               main    #1038       +/-   ##
=============================================
+ Coverage     33.25%   49.60%   +16.34%     
- Complexity      759     1218      +459     
=============================================
  Files           105      106        +1     
  Lines          9748     9763       +15     
  Branches       1010     1004        -6     
=============================================
+ Hits           3242     4843     +1601     
+ Misses         5946     4292     -1654     
- Partials        560      628       +68     
Impacted Files Coverage Δ
...main/java/com/shaft/gui/element/SikuliActions.java 0.00% <0.00%> (ø)
...om/shaft/gui/internal/image/ScreenshotManager.java 38.46% <0.00%> (+5.94%) ⬆️
...om/shaft/listeners/CucumberTestRunnerListener.java 78.68% <0.00%> (ø)
...a/com/shaft/listeners/internal/CucumberHelper.java 6.25% <0.00%> (ø)
.../java/com/shaft/listeners/internal/JiraHelper.java 15.62% <0.00%> (ø)
...performance/internal/LightHouseGenerateReport.java 0.00% <0.00%> (ø)
...java/com/shaft/properties/internal/Properties.java 0.00% <ø> (ø)
...in/java/com/shaft/properties/internal/Visuals.java 100.00% <ø> (+35.29%) ⬆️
.../com/shaft/tools/internal/security/GoogleTink.java 13.33% <0.00%> (ø)
...haft/tools/internal/tms/XrayIntegrationHelper.java 0.00% <0.00%> (ø)
... and 20 more

... and 50 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MohabMohie MohabMohie merged commit cb560dd into ShaftHQ:main Apr 7, 2023
@magdyheiba magdyheiba deleted the PropertiesTestsCoverage branch April 7, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants