Enhance light housefeature2 #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2- Add Test class to test the report generation 3- Add the Node JS script to the project folder
1- Add GoogleChromePort Prop
Add new TC Edit DriverFactoryHelper
2- Edit the Test classes to test the report generation 3- Edit Node js Script
1- Add DriverFactoryHelper.java to use options
…into LHFixChanges � Conflicts: � src/main/java/io/github/shafthq/shaft/driver/DriverFactoryHelper.java
Lh fix changes2
1- Add AddNodeModules.sh file
Update script3
…into UpdateScript3 � Conflicts: � AddNodeModules.sh
Feature/lighthouse
Add Latest Files
Feature/lighthouse1
Add new Enhancements on Lighthouse class
Codecov Report
@@ Coverage Diff @@
## main #1050 +/- ##
=============================================
+ Coverage 33.36% 49.36% +16.00%
- Complexity 760 1230 +470
=============================================
Files 106 106
Lines 9761 9806 +45
Branches 1004 1010 +6
=============================================
+ Hits 3257 4841 +1584
+ Misses 5936 4339 -1597
- Partials 568 626 +58
... and 66 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MohabMohie
reviewed
Apr 14, 2023
| public void writeNodeScriptFileInProjectDirectory() { | ||
| List<String> commandsToServeLHReport; | ||
| if (SystemUtils.IS_OS_WINDOWS) { | ||
| commandsToServeLHReport = Arrays.asList("import puppeteer from 'puppeteer';\n" + |
There was a problem hiding this comment.
Try using a multiline string to enhance this block
MohabMohie
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.