Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1048 #1058

Conversation

MohabMohie
Copy link
Contributor

  • changes the way click action is performed to align with the new engine core (actions are taken inside the unified fluent wait)
  • this is a major change to the click action logic and needs to be thoroughtly tested

- changes the way click action is performed to align with the new engine core (actions are taken inside the unified fluent wait)
- this is a major change to the click action logic and needs to be thoroughtly tested

Signed-off-by: MohabMohie <Mohab.MohieElDeen@outlook.com>
@MohabMohie MohabMohie added bug Something isn't working enhancement New feature or request java Pull requests that update Java code complex complex feature/issue requires time labels Apr 15, 2023
@MohabMohie MohabMohie self-assigned this Apr 15, 2023
@MohabMohie MohabMohie linked an issue Apr 15, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #1058 (806b578) into main (5832dfb) will decrease coverage by 1.01%.
The diff coverage is 64.51%.

@@             Coverage Diff              @@
##               main    #1058      +/-   ##
============================================
- Coverage     50.57%   49.57%   -1.01%     
+ Complexity     1239     1212      -27     
============================================
  Files           107      107              
  Lines          9690     9686       -4     
  Branches        988      989       +1     
============================================
- Hits           4901     4802      -99     
- Misses         4158     4263     +105     
+ Partials        631      621      -10     
Impacted Files Coverage Δ
...in/java/com/shaft/properties/internal/Visuals.java 100.00% <ø> (ø)
...com/shaft/driver/internal/DriverFactoryHelper.java 39.32% <50.00%> (-1.68%) ⬇️
...aft/gui/element/internal/ElementActionsHelper.java 47.59% <53.33%> (-8.59%) ⬇️
...aft/gui/element/internal/FluentElementActions.java 45.00% <83.33%> (-0.08%) ⬇️
...n/java/com/shaft/enums/internal/ElementAction.java 100.00% <100.00%> (ø)
...com/shaft/gui/internal/locator/LocatorBuilder.java 82.53% <100.00%> (-2.08%) ⬇️
...aft/gui/internal/locator/ShadowLocatorBuilder.java 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

- commenting non-globally reproducible test
- @key("whenToTakePageSourceSnapshot")
      @DefaultValue("Never")
      String whenToTakePageSourceSnapshot();

Signed-off-by: MohabMohie <Mohab.MohieElDeen@outlook.com>
@MohabMohie MohabMohie merged commit 048fe4d into main Apr 16, 2023
@MohabMohie MohabMohie deleted the 1048-bug-shadowdom-feature-not-working-with-usercentrics-cookie-modal branch April 16, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complex complex feature/issue requires time enhancement New feature or request java Pull requests that update Java code
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: ShadowDOM feature not working with Usercentrics cookie modal
1 participant