Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultipleElementsFoundException #1469

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Conversation

MohabMohie
Copy link
Contributor

  • will now be thrown without waiting for timeout to conclude for all actions that are performed inside the fluent wait block

- will now be thrown without waiting for timeout to conclude for all actions that are performed inside the fluent wait block
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (1c2d217) 51.21% compared to head (063fd90) 51.98%.

Files Patch % Lines
...ain/java/com/shaft/gui/browser/BrowserActions.java 0.00% 26 Missing ⚠️
...aft/gui/element/internal/ElementActionsHelper.java 56.25% 3 Missing and 4 partials ⚠️
.../main/java/com/shaft/gui/element/AlertActions.java 25.00% 3 Missing ⚠️
...ain/java/com/shaft/gui/element/ElementActions.java 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1469      +/-   ##
============================================
+ Coverage     51.21%   51.98%   +0.77%     
- Complexity     1292     1325      +33     
============================================
  Files           109      109              
  Lines         10079    10081       +2     
  Branches       1012     1015       +3     
============================================
+ Hits           5162     5241      +79     
+ Misses         4287     4216      -71     
+ Partials        630      624       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
- handle relative locators for nested actions
- enhance alert actions constructor to be able to manage an alert object.
- fix animated gif scaling issue.
- remove deprecated browseractions
- add getContext, setContext, getWindowHandles, getContextHandles to browseractions
- create coverage tests
- fix element action: submit form using javascript
- handle type failures similar to click failures (screenshot, exception stacktrace) thanks to @ahmedzanoon
- remove unused methods in ElementActionsHelper
- ensure immediate failure in case of InvalidSelectorException
- throw multipleElement exception only in case a nested action should be performed
- add basicHoverAndClickTest to HoverTests
- ensure that SearchOptimizationTest would only run if not on safari
@MohabMohie MohabMohie merged commit ea0724e into main Jan 26, 2024
25 of 26 checks passed
@MohabMohie MohabMohie deleted the fix-multiple-elements-found-exception branch January 26, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: MultipleElementsFound exception is thrown after the action is taken with click, type and other actions
1 participant