-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete dynamic properties for tests/Zend/** #289
Complete dynamic properties for tests/Zend/** #289
Conversation
Then you have to move those unrelated commits to separate PR. Remove rector changes from this PR and submit as a separate PR. You could submit them after this is merged if that makes a more logical order. also noticed some commits have same title, these probably could be joined or the title is wrong? Also, remove "PHP 8.2: "prefix from messages to make them shorter (some are still wrapped over 72 chars), if someone wants to know if they are PHP 8.2 related they can see that from PR or from merge commit. |
Firstly Mr @glensc please review #290 After that i will rebase and fix this PR according to your advice The logical order is:
|
what does this sentence mean? what mistake? |
I mean something bad like
|
Syntax errors will be caught by CI:
still, that sentence doesn't make any sense to me. remove it? |
btw, all properties were added as public. probably doesn't matter at all for tests what their visibility is. so not worth putting time into fixing t hem, unless you have clever way of doing that. |
Oh it's done by run |
so, rector can figure out which property needs to be public, which one can be private/protected? |
I think we can't do that at this time |
that's why I said for |
b8fcc06
to
f89ef2e
Compare
Mr. @glensc I followed your advice
|
I actually opened a bug, after trying this too Currently they hardcoded the missing properties to "MODIFIER_PUBLIC" So before i ran rector, i manually edited the line to MODIFIER_PROTECTED :) |
@Jimbolino thanks you, a good trick for test suite ^^ |
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Amf/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Application/Bootstrap/BootstrapTest.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Cache/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Captcha/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Config/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Controller/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Crypt/Rsa/RsaTest.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Date/DateObjectTest.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Dojo/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Dom/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/EventManager/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Feed/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Mail/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Measure/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Mobile/Push/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Oauth/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/OpenId/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Queue/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Stdlib/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Validate/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/XmlRpc/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/View/Helper/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/CurrencyTest.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/DateTest.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/FilterTest.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/LoaderTest.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/ValidateTest.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Gdata/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Service/AllTests.php
PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated Verified by: (not working right now, need migrate code Zend_Test_PHPUnit_ControllerTestCase support phpunit 9) docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Test/PHPUnit/AllTests.php
f89ef2e
to
e352dd1
Compare
Too many changes to manually review. But as tests pass, this should be good enough. |
Ported from Shardj/zf1-future#289 PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
Ported from Shardj/zf1-future#289 PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
Ported from Shardj/zf1-future#289 PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
Ported from Shardj/zf1-future#289 PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
Ported from Shardj/zf1-future#289 PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
Ported from Shardj/zf1-future#289 PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
Fix bug PHP 8.2: Dynamic Properties are deprecated' for test suite tests/Zend/**
Work Done
tests/Zend/**
at PR GitHub actions phpunit on php 8.2 & Fix bug on php 8.2 #275rector
to add real properties needed by test case classtests/Zend/**
because i concerns #AllowDynamicProperties will removed in php >= 8.3complete dynamic properties to class
zf1-future/rector.php
Lines 16 to 17 in 1f1cc46
What next
After this PR merged into master, i will do the same thing for library/Zend to eliminate issue
Creation of dynamic property xxx is deprecated
in library/ZendFor Reviewer
Please keep my git commit signing by merge branch, please don't use rebase ^^