Incorrect behavior of CompleteDynamicPropertiesRector

[Jimbolino]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.org/demo/d322d190-3178-4bf7-9877-921b8ccb698b

<?php

class BaseClass
{
    public function run()
    {
        $this->test = true;
    }
}

class NormalClass extends BaseClass
{
    protected bool $test;
    
    public function run()
    {
        $this->test = true;
    }
}

Responsible rules

• CompleteDynamicPropertiesRector

Expected Behavior

Should try to match the visibility of the other class

[hungtrinh]

#6806 (comment)

1. Due to PHPStan design that we inherit here, we can only work with current context. That means PHPStan does not know about all use cases, just about current class. E.g. dead public methods cannot be reported etc. This might change in the future, but so far there is nothing we can do about it.

oops look like limit of PHPStan

[TomasVotruba]

Indeed, thanks for checking.
It's better to avoid property juggling, protected properties and inheritance in general. They allow such leaky design that is hard to process and error prone.