Update Hostname.php #72
Conversation
Update list of available tlds based on https://data.iana.org/TLD/tlds-alpha-by-domain.txt
Change project name
composer.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "shardj/zf1-future", | |||
| "name": "sandervanleeuwen/zf1-future", | |||
There was a problem hiding this comment.
Just need to remove this change and I'll merge the PR
There was a problem hiding this comment.
Whoops. I changed the name in order to use my fork as an alternative for composer until these changes have been merged, but should probably have done so on a different branch. Reverted it now.
There was a problem hiding this comment.
this happened because you created pull request from your master branch.
|
Sorry for taking so long to get around to you. By the way I highly recommend you change over to use https://github.com/jeremykendall/php-domain-parser or another library |
This reverts commit 898ecd3.
|
Thanks for the suggestion. I do like the idea, but we use the old Zend validation mechanisms here and there. It's a bit much to replace those validation classes with a completely different library for the support of one or two additional tld's (which are barely used by our userbase anyway). |
|
@SanderVanLeeuwen did you use some script to update this? please share! |
|
I would guess that it was a simple copy paste along with some regex substitutions to add in commas and indentation. Something like: Capture: `^([A-Z\-0-9]+)$` Replace: ` \L$1,` Here's a regex 101 link. https://regex101.com/r/KAC7yw/1 |
Update list of available tlds based on https://data.iana.org/TLD/tlds-alpha-by-domain.txt