Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Temporary fix for gulp-header bug #137

Merged
merged 2 commits into from
Jun 20, 2016
Merged

Temporary fix for gulp-header bug #137

merged 2 commits into from
Jun 20, 2016

Conversation

mike-morr
Copy link
Contributor

@mike-morr mike-morr commented Jun 20, 2016

Q A
Bug fix? yes
New feature? no
New sample? no
Related issues? reported via gitter

What's in this Pull Request?

Fixes temporary build issue caused by a gulp-header bug

@patrick-rodgers
Copy link
Contributor

So the issue is with gulp-header and the fix is to make sure were are up to a newer version? Just want to make sure I understand what happened and that it wasn't something we did. Though odd I don't see it - so I must have still a version from before this bug was introduced in gulp-header. Sound right?

@mike-morr
Copy link
Contributor Author

I fixed the link to the issue in the gulp-header repo. The issue is they introduced a bug in the latest version which we pull during npm install. 1.8.3 so we temporarily need to hardcode directly to 1.8.2 until they merge the fix and release an update. They apparently broke a lot of folk's repos. The only thing we could have done differently is to specify a specific version instead of letting it pull the most recent update.

@s-KaiNet
Copy link
Contributor

Yes, it looks like you said. Right after npm install I'm having the latest gulp-header 1.8.3, which has a bug. You should be able to reproduce the issue by deleting folder node_modules/gulp-header and running npm install to restore 1.8.3 version.

@patrick-rodgers
Copy link
Contributor

Got it, ok - nice work finding this. I'll go ahead and merge into dev. If you could track the bug on their side we can update back to latest once they get it sorted out.

@patrick-rodgers patrick-rodgers merged commit 7327d51 into SharePoint:dev Jun 20, 2016
@mike-morr mike-morr mentioned this pull request Jun 20, 2016
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants