Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People Picker control #19

Closed
russgove opened this issue Dec 19, 2017 · 11 comments
Closed

People Picker control #19

russgove opened this issue Dec 19, 2017 · 11 comments
Milestone

Comments

@russgove
Copy link
Contributor

Category

[x] Enhancement

[ ] Bug

[ ] Question
There is one in the poroperty pane controls, bit we need one in the webpart controls too. Need to be able to let users select from anyone , or just members of a group (like the classic one).

@russgove
Copy link
Contributor Author

russgove commented Jan 7, 2018

Needs to be able to select a group from sitegroups too!

@AsishP
Copy link
Contributor

AsishP commented Jan 14, 2018

@VesaJuvonen, has anyone started looking into this control. I had already built a similar control for people picker (Site Users only right now) using Office Fabric React in one of my recent projects. Had to go through a extended dev process to extend and program the control. Including a custom validation was really tough too. Really feel it would a help to lot of dev with this control.

If possible, I would be happy to contribute that control here. Have attached screenshot from my project below. Don't know how does contribution works here. Could you please let me know.

peoplepickercontrol

@estruyf
Copy link
Member

estruyf commented Jan 16, 2018

@AsishP feel free to contribute to the project. I'm not aware of anyone working on this functionality. This control would be a great addition. You can find more information how to contribute to the project here: https://github.com/SharePoint/sp-dev-fx-controls-react/blob/master/docs/guides/index.md

@AsishP
Copy link
Contributor

AsishP commented Jan 17, 2018

Thanks @estruyf. I will go through the docs and let you know if there are any queries.

@AsishP
Copy link
Contributor

AsishP commented Apr 30, 2018

Hi @estruyf , I am ready with the first version of the People picker control. Before I put up a PR, I have got a query regarding tests. I have don't any unit tests with React or SPFx yet. Is it needed for the control? If yes, could you please redirect me to the steps for the same or the framework (mocha or chai) or npm package I could use for the same.

@AsishP
Copy link
Contributor

AsishP commented May 3, 2018

Hi all, I have submitted the PR for Peoplepicker control. Please test and let me know if there are any questions or issues. Thanks.

@estruyf estruyf added this to the 1.5.0 milestone Jun 15, 2018
@estruyf estruyf closed this as completed Jun 20, 2018
@rchivert
Copy link

rchivert commented Jul 13, 2018

Is there a working example for the peoplepicker control? I tried to use it and getting errors...

(I'm using it in the "Use custom dialog boxes with SharePoint Framework Extensions" example: https://docs.microsoft.com/en-us/sharepoint/dev/spfx/extensions/guidance/using-custom-dialogs-with-spfx

@amolkhedekar01
Copy link

I am using people picker and i need to clear people picker on button click, any solution for clear people picker on button click.(i am using SPFX react).

Please let me know if anybody have solution.

@sympmarc
Copy link

@amolkhedekar01 Better to create a new issue. This one has been closed for a long time.

That said, in 1.12.0 (there was a bug previously - fixed in #234), you can pass an empty array to defaultSelectedUsers:

defaultSelectedUsers={(this.state.filters.ShipmentRequestor && this.state.filters.ShipmentRequestor.length) ? [this.state.filters.ShipmentRequestor.email] : []}

@amolkhedekar01
Copy link

Thanks its worked

@prabhu8323
Copy link

@amolkhedekar01 Could you please share the working line of code. As I am also facing same issue. Thansk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants