Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to import IFrameDialog correctly from the library #53

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

AJIXuMuK
Copy link
Collaborator

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? mentioned in #52

What's in this Pull Request?

  • IFrameDialog export changed from default to general one to be importable from the library in the same way as other controls
  • IFrameDialog example is added to the test web part page of the project

@codecov-io
Copy link

Codecov Report

Merging #53 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #53   +/-   ##
=======================================
  Coverage   77.91%   77.91%           
=======================================
  Files          10       10           
  Lines         335      335           
  Branches       78       78           
=======================================
  Hits          261      261           
  Misses         55       55           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f004a95...06bb4f9. Read the comment docs.

@estruyf estruyf merged commit 06bb4f9 into pnp:dev Mar 23, 2018
@estruyf
Copy link
Member

estruyf commented Mar 23, 2018

Thanks @AJIXuMuK I merged it and will get added to v1.2.4.

@AJIXuMuK AJIXuMuK deleted the iframe-reference-fix branch March 23, 2018 19:30
@AJIXuMuK
Copy link
Collaborator Author

Awesome!
Thanks for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants