Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #5 Allow for CharData to be keyed #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolve #5 Allow for CharData to be keyed #6

wants to merge 1 commit into from

Conversation

ciauri
Copy link

@ciauri ciauri commented Mar 15, 2018

  • In the presence of attributes and child elements, chardata values will be keyed on a custom value provided by the user via the new property characterDataToken on the XMLDecoder

@ciauri
Copy link
Author

ciauri commented Mar 16, 2018

Note that this breaks current implementations since, if the key is set, all attributes, values, and child elements will be serialized into the container dictionary.

@ciauri
Copy link
Author

ciauri commented May 18, 2018

@ShawnMoore - Mind giving this a look when you get a chance? How do you feel about this implementation?

@ciauri
Resolve ShawnMoore#5 Allow for CharData to be keyed
6ca5339 
- In the presence of attributes and child elements, chardata values will be keyed on a custom value provided by the user via the new property `characterDataToken ` on the XMLDecoder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ciauri