Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Markdown parser and articulate markdown data type to support nicely formatted code #341

Shazwazza opened this issue Jul 31, 2020 · 3 comments


Copy link

Shazwazza commented Jul 31, 2020

I think the MD parser could do with a lot of help especially when using code blocks. I can't recall if articulate ships with it's own md processors or if it just relies on Umbraco's but it's not great.

It would be great to support code blocks with hints like GH supports: like ```cs

but it doesn't. Also the code blocks rendered use <p><code> instead of <p><pre><code> which is not correct.

Anyways, seems like a lot to be desired :)

Copy link

simonech commented Jul 31, 2020 via email

Copy link
Owner Author

Sounds awesome!

Shazwazza added a commit that referenced this issue Jan 18, 2021
Copy link
Owner Author

Shazwazza commented Jan 18, 2021

This is working with rev: 40ada4e

Things TODO:

  • Update the nuspec to include the additional dependencies (markdig and WebStoating.Markdig.Prism)
  • Update the other themes to include the Prism client libs from cdn
  • Update the umbraco package xml to ensure that the articulate Articulate.MarkdownEditor is used instead of the Umbraco.MarkdownEditor for data types and property types
  • [ ] Update the upgrader to change the ArticulateMarkdown data type to use the Articulate.MarkdownEditor

Since this is based on Prism it is very easy for people to restyle however they want.

@Shazwazza Shazwazza added this to the 4.3.0 milestone Mar 11, 2021
@Shazwazza Shazwazza changed the title Update the Markdown parser and markdown content type to better support code snippets Update the Markdown parser and articulate markdown data type to support nicely formatted code Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

2 participants