Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using deepGPy choleskies? #4

Closed
mathDR opened this issue Sep 22, 2015 · 3 comments
Closed

Using deepGPy choleskies? #4

mathDR opened this issue Sep 22, 2015 · 3 comments

Comments

@mathDR
Copy link

mathDR commented Sep 22, 2015

In coldeep.py there is a line:

from GPy.util.choleskies import indexes_to_fix_for_low_rank

But within the package there is a choleskies.py file containing the same function. Do you mean to use the GPy version?

@jameshensman
Copy link
Contributor

Hi Dan,

Yeah, there's some functionality that was written for DeepGPy that I later
moved (copied) into GPy because it was more generally useful, so sometimes
there will be a clash.

Cleaning up DeepGPy is on the agenda!

James.

On 22 September 2015 at 19:23, Dan Marthaler notifications@github.com
wrote:

In coldeep.py there is a line:

from GPy.util.choleskies import indexes_to_fix_for_low_rank

But within the package there is a choleskies.py file containing the same
function. Do you mean to use the GPy version?


Reply to this email directly or view it on GitHub
#4.

@mathDR
Copy link
Author

mathDR commented Sep 23, 2015

Sounds good James. Does this still imply that the devel branch of GPy is the one to link to? Or will you be linking to the master branch after the cleanup?

And I think we can close this issue.

Dan

@mathDR mathDR closed this as completed Sep 23, 2015
@jameshensman
Copy link
Contributor

Hi Dan,

I think everything should work with GPy 0.8 now.

James.

On 23 September 2015 at 16:02, Dan Marthaler notifications@github.com
wrote:

Sounds good James. Does this still imply that the devel branch of GPy is
the one to link to? Or will you be linking to the master branch after the
cleanup?

And I think we can close this issue.

Dan


Reply to this email directly or view it on GitHub
#4 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants