Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simplified chinese #199

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Add simplified chinese #199

merged 3 commits into from
Jul 11, 2024

Conversation

wang19980501
Copy link
Contributor

Add simplified chinese

ShiftHackZ
ShiftHackZ reviewed Jun 16, 2024
View reviewed changes
.idea/inspectionProfiles/Project_Default.xml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, revert this file back.

@ShiftHackZ
Copy link
Owner

Hi, thanks for you contribution.
To fully support "zh" locale with latest android translation APIs, could you also please make a few adjustments:

  1. Add "zh" locale to the file app/build.gradle at line 38 like this:
resourceConfigurations = ["en", "ru", "uk", "tr", "zh"]
  1. Add <locale android:name="zh"/> to the file app/src/main/res/xml/locale_config.xml, for example:
<locale-config>
    ...
    <locale android:name="zh"/>
</locale-config>

@ShiftHackZ ShiftHackZ added the localization Feature or request related to app translation / localization. label Jun 16, 2024
@ShiftHackZ ShiftHackZ changed the base branch from master to feature/zh-translation July 11, 2024 18:22
@ShiftHackZ ShiftHackZ merged commit 678e0b2 into ShiftHackZ:feature/zh-translation Jul 11, 2024
ShiftHackZ added a commit that referenced this pull request Jul 11, 2024
@ShiftHackZ @wang19980501
Add simplified chinese (#199) (#207)
ccb4c0b 
* Add simplified chinese (#199)

* Add language: Simplified Chinese

* Add language: Simplified Chinese

* Revert Project_Default.xml

* Revert Project_Default.xml

* Support android google play translation APIs

---------

Co-authored-by: 佳豪 <1581465757@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiftHackZ ShiftHackZ ShiftHackZ left review comments

Assignees
No one assigned
Labels
localization Feature or request related to app translation / localization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wang19980501 @ShiftHackZ