[FR] Parser #4
[FR] Parser #4
Conversation
implented method for converting `R type instructions` parsing.
add quick parser code, not clean, just to test. also the `labels` part is not finished.
parsing I and J types.
remove `label` stuff, and handle the special instructions for Shifting and `MOVI`. as they require less registers.
|
@AhmedNasserG @ShimaaBetah @MohammadOTaha @Abdulaziz-Hassan |
aboueleyes
added
ready for revirew
in progress
and removed
in progress
not ready yet
labels
|
Please delete these following files from the PR as the updated ones are in this pull request #9 so they don't conflict |
aboueleyes
dismissed stale reviews from Abdulaziz-Hassan and AhmedNasserG
not finished yet
ok @Abdulaziz-Hassan , if i deleted them they will be deleted from the repo after merging, I will handle them at merging, don't worry :) |
fixed JumpInstruction to handle Immediate values also handle comments and empty lines.
aboueleyes
requested review from
Abdulaziz-Hassan,
AhmedNasserG,
MohammadOTaha and
ShimaaBetah
|
All in all great job 👏 perhaps maybe adding more tests would be better try using parameterized tests see these articles for more info Parameterized Tests in JUnit, Parameterized Tests in JUnit5 |
|
Thank you for your review, Abdulaziz 🤝 |
handle negative numbers, refactor some methods, add some tests : )
Adding parser
takes a
text fileand return a list ofbinary instructions