Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining stage 1 fixes #283

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Remaining stage 1 fixes #283

merged 3 commits into from
Sep 13, 2019

Conversation

JLTastet
Copy link
Contributor

This completes the stage 1 changes.

After these commits, futurize -wn -1 **/*.py is a no-op.

I ran the basic workflow from the README (without the pickler fix), and so far everything works fine.

Please test it and report any issues here.

`futurize -wn --fix=has_key **/*.py`
`futurize -wn --fix=ne **/*.py`
`futurize -wn --fix=next_call **/*.py`
@JLTastet JLTastet mentioned this pull request Sep 13, 2019
46 tasks
@siscia
Copy link
Contributor

siscia commented Sep 13, 2019

It might not be a problem, but as I mentioned, if I were in you I would run it on all the directories.

smosciat@simo:/tmp/FairShip$ git branch
  master
* stage1
smosciat@simo:/tmp/FairShip$ git remote -v
origin	https://github.com/JLTastet/FairShip.git (fetch)
origin	https://github.com/JLTastet/FairShip.git (push)
smosciat@simo:/tmp/FairShip$ git branch
  master
* stage1
smosciat@simo:/tmp/FairShip$ futurize -wn -1 **/**/*.py
RefactoringTool: Skipping optional fixer: idioms
RefactoringTool: Skipping optional fixer: ws_comma
RefactoringTool: No changes to housekeeping/cpplint/cpplint.py
RefactoringTool: No changes to macro/obsolete/genfitMain.py
RefactoringTool: No changes to macro/obsolete/genfitShip.py
RefactoringTool: No changes to macro/obsolete/run_sim.py
RefactoringTool: No changes to macro/obsolete/ShipAnaWithVertexing.py
RefactoringTool: No changes to millepede/tools/readMilleBinary.py
RefactoringTool: Files that need to be modified:
RefactoringTool: housekeeping/cpplint/cpplint.py
RefactoringTool: macro/obsolete/genfitMain.py
RefactoringTool: macro/obsolete/genfitShip.py
RefactoringTool: macro/obsolete/run_sim.py
RefactoringTool: macro/obsolete/ShipAnaWithVertexing.py
RefactoringTool: millepede/tools/readMilleBinary.py

@ThomasRuf ThomasRuf merged commit f6d3a6b into ShipSoft:master Sep 13, 2019
@JLTastet
Copy link
Contributor Author

@siscia I did what you suggested, but it does not result in any extra changes.

@JLTastet JLTastet deleted the stage1 branch September 13, 2019 13:52
owtscharenko pushed a commit to owtscharenko/FairShip that referenced this pull request Feb 19, 2020
* Replace `d.has_key(k)` by `k in d`.

`futurize -wn --fix=has_key **/*.py`

* Replace <> by !=

`futurize -wn --fix=ne **/*.py`

* Replace `o.next()` by `next(o)`.

`futurize -wn --fix=next_call **/*.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants