Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use phonenumbers to validate #7

Closed
wants to merge 4 commits into from

Conversation

tistaharahap
Copy link

@tistaharahap tistaharahap commented Jul 24, 2023

This PR tries to validate phone numbers using a widely accepted library phonenumbers - https://pypi.org/project/phonenumbers/

Also added country code validation to use pycountry - https://pypi.org/project/pycountry/

I'm fairly new to contributing for OCF, please advise if I'm not doing this correctly. Other than the source code additions, I bumped the version to 1.0.2.dev2.

@regebro
Copy link
Contributor

regebro commented Oct 25, 2023

Thanks, it's looks good, but I'm not sure we want to necessarily enforce these things. We do want to enforce that data adheres to the OCF standard, and currently we verify that the data matches the OCF regex patterns. But I think that data verification beyond that is out of scope for PyOCF.

@regebro regebro closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants