Once again fix the namespace handling #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regebro
force-pushed
the
lregebro-umpteenth-namespace-effort
branch
from
02b3697
to
9aade5a
Compare
The original fix fixed too much. This fix does the right thing, but changes the return format of the parser by adding a field for the namespace prefix.
regebro
force-pushed
the
lregebro-umpteenth-namespace-effort
branch
from
9aade5a
to
3b82974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original fix fixed too much. This fix does the right thing, but changes
the return format of the parser by adding a field for the namespace prefix.