Fix Python workflow #170
Merged
Fix Python workflow #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardnuno
force-pushed
the
fix-python-workflow
branch
3 times, most recently
from
2b0e8f0
to
fa147b5
Compare
richardnuno
force-pushed
the
fix-python-workflow
branch
from
fa147b5
to
04b4176
Compare
Running the python-tests workflow against Python 3.8 was causing pylint issues. This temporarily skips running the tests against 3.8 as well as linting for all versions since 3.8 is used in the workflow. More recent versions of Python should be supported but this unblocks releases for now.
richardnuno
force-pushed
the
fix-python-workflow
branch
from
9a14d65
to
75b7a37
Compare
kimbilida
reviewed
Sep 14, 2021
Comment on lines
+1
to
+13
| # This file is for Shopify employees development environment. | ||
| # If you are an external contributor you don't have to bother with it. | ||
| name: ci-queue | ||
|
|
||
| vm: | ||
| image: /opt/dev/misc/railgun-images/default | ||
| ip_address: 192.168.64.245 | ||
| memory: 1G | ||
| cores: 2 | ||
| volumes: | ||
| root: 512M | ||
| services: | ||
| - redis |
There was a problem hiding this comment.
|
@casperisfine any thoughts on whether there should be a version bump with these changes? |
|
Not particularly no. I mean this just fixes the CI. Not much point cutting a release. |
kimbilida
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
The current version is 0.20.9 and hasn't been tagged or released so it seems fine to not have to bump it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the python-tests workflow against Python 3.8 was causing pylint issues.
This temporarily skips running the tests against 3.8 as well as linting for all versions since 3.8 is used in the workflow.
More recent versions of Python should be supported but this unblocks releases for now.