Enable running the ruby tests with alternate redis host/port #202
Conversation
|
Just wondering, why is this required? Because you can't inject the port? |
|
yeah, i was trying to run the test suite on spin where redis is on a non-standard port and the railgun host doesn't work |
rwstauner
changed the title
rwstauner
changed the title
rwstauner
changed the title
rwstauner
changed the title
ruby/test/support/redis_helper.rb
Outdated
| @@ -0,0 +1,17 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module RedisHelper | |||
There was a problem hiding this comment.
Not sure about introducing a new concept here. Could we not just use REDIS_URL which is $REDIS_HOST:$REDIS_PORT
There was a problem hiding this comment.
Yeah, REDIS_URL should have priority.
There was a problem hiding this comment.
REDIS_URL includes the database (which tends to be 0), where as the tests have been using 7.
If that isn't a concern i'm happy to switch to it.
Do we want to prefer REDIS_URL before HOST/PORT, or just use URL and drop support for HOST/PORT altogether?
There was a problem hiding this comment.
Yeah, not a concern. Let's just go with REDIS_URL only.
There was a problem hiding this comment.
I'm still wondering if we need this abstraction at all if it's just a ENV.fetch?
There was a problem hiding this comment.
there's still the default string being repeated but at this point we could inline it
rwstauner
force-pushed
the
rwstauner/redis-port
branch
from
6e051cb
to
a773cfc
Compare
rwstauner
force-pushed
the
rwstauner/redis-port
branch
from
a773cfc
to
bab916b
Compare
Tests pass with
devon macs anddev testworks on spin (where redis is on a non-standard port and the railgun host does not exist).