Export flaky tests #211
Merged
Export flaky tests #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBr
reviewed
May 12, 2023
ChrisBr
reviewed
May 12, 2023
ChrisBr
reviewed
May 12, 2023
nikita8
force-pushed
the
nikita8/export-flaky-tests
branch
3 times, most recently
from
7e40e9d
to
349d6ff
Compare
| redis.pipelined do |pipeline| | ||
| pipeline.sadd( | ||
| key('flaky-reports'), | ||
| id.dup.force_encoding(Encoding::BINARY) |
There was a problem hiding this comment.
Suggested change
| id.dup.force_encoding(Encoding::BINARY) | |
| id.b |
ChrisBr
reviewed
May 16, 2023
nikita8
force-pushed
the
nikita8/export-flaky-tests
branch
from
085a794
to
5b7e5ab
Compare
ChrisBr
reviewed
May 16, 2023
nikita8
force-pushed
the
nikita8/export-flaky-tests
branch
2 times, most recently
from
ecd87eb
to
4de2cbc
Compare
ChrisBr
approved these changes
May 17, 2023
| @@ -48,10 +48,23 @@ def record_error(id, payload, stats: nil) | |||
| end | |||
|
|
|||
| def record_success(id, stats: nil) | |||
| redis.pipelined do |pipeline| | |||
| errror_reports_deleted_count, requeued_count, _ = redis.pipelined do |pipeline| | |||
There was a problem hiding this comment.
Suggested change
| errror_reports_deleted_count, requeued_count, _ = redis.pipelined do |pipeline| | |
| error_reports_deleted_count, requeued_count, _ = redis.pipelined do |pipeline| |
casperisfine
approved these changes
May 17, 2023
nikita8
force-pushed
the
nikita8/export-flaky-tests
branch
from
4de2cbc
to
96a754a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export list of flaky tests.
Re-queued jobs are not marked as failed. So, to determine the flakiness I am looking into the re-queue count for the test or check if it failed earlier and passed on job retry.