Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react peer dep #2791

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Remove react peer dep #2791

merged 3 commits into from
Sep 6, 2023

Conversation

matteodepalo
Copy link
Contributor

PR for stable branch.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/theme-code-tools
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@matteodepalo matteodepalo merged commit b693095 into stable/3.49 Sep 6, 2023
1 check passed
@matteodepalo matteodepalo deleted the remove-react-peer-dep branch September 6, 2023 17:47
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.49.1";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.49.0";
\ No newline at end of file

@shopify-shipit shopify-shipit bot temporarily deployed to stable_3_49 September 6, 2023 17:54 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to nightly September 7, 2023 10:59 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to experimental September 13, 2023 13:24 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production October 19, 2023 13:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant