Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New extension buyer consent capability #2862

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

joshlbaker
Copy link
Contributor

WHY are these changes introduced?

Resolves: https://github.com/Shopify/checkout-web/issues/25433

This PR relates to the SMS Consent project being worked on in Checkout Extensibility.

WHAT is this pull request doing?

  • Adds a new extension capability called collect_buyer_consent with it's own sub-capability/policy for sms_marketing.
  • Note that email_marketing will be added in the future.
  • Updates capability types to accept recursive typing for nested capabilities (new concept for this PR)
  • Updates tests which confirms the following configuration works as expected
[extesnions.capabilities.collect_buyer_consent]
sms_marketing = true

and legacy config

[capabilities.collect_buyer_consent]
sms_marketing = true

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@joshlbaker joshlbaker changed the title fix merge conflicts New extension buyer consent capability Sep 19, 2023
@github-actions
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/theme-code-tools
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 73.87% 6047/8186
🟡 Branches
71.09% (+0.02% 🔼)
2953/4154
🟡 Functions 72.3% 1537/2126
🟡 Lines 75.21% 5739/7631
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / function.ts
86.36%
85% (-1.36% 🔻)
83.33% 86.36%
🟡
... / utilities.ts
57.89% (-2.11% 🔻)
69.23% 33.33%
68.75% (-1.84% 🔻)

Test suite run success

1430 tests passing in 669 suites.

Report generated by 🧪jest coverage report action from 075ae2c

@joshlbaker joshlbaker marked this pull request as ready for review September 21, 2023 16:45
@github-actions

This comment has been minimized.

@joshlbaker
Copy link
Contributor Author

/shipit

@joshlbaker joshlbaker added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 81c5dee Sep 21, 2023
1 check passed
@joshlbaker joshlbaker deleted the jb/new-consent-capability branch September 21, 2023 18:50
@shopify-shipit shopify-shipit bot temporarily deployed to nightly September 22, 2023 09:22 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production October 19, 2023 13:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants