-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New extension buyer consent capability #2862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlbaker
changed the title
fix merge conflicts
New extension buyer consent capability
Sep 19, 2023
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
joshlbaker
force-pushed
the
jb/new-consent-capability
branch
from
September 19, 2023 18:27
f4af95e
to
b5b45c5
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success1430 tests passing in 669 suites. Report generated by 🧪jest coverage report action from 075ae2c |
This comment has been minimized.
This comment has been minimized.
joshlbaker
force-pushed
the
jb/new-consent-capability
branch
from
September 21, 2023 17:25
b5b45c5
to
aca1ec0
Compare
joshlbaker
commented
Sep 21, 2023
isaacroldan
approved these changes
Sep 21, 2023
joshlbaker
force-pushed
the
jb/new-consent-capability
branch
from
September 21, 2023 17:48
4267892
to
075ae2c
Compare
/shipit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves: https://github.com/Shopify/checkout-web/issues/25433
This PR relates to the SMS Consent project being worked on in Checkout Extensibility.
WHAT is this pull request doing?
collect_buyer_consent
with it's own sub-capability/policy forsms_marketing
.email_marketing
will be added in the future.and legacy config
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.