Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run config commands outside app root folder #2873

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

alvaro-shopify
Copy link
Contributor

WHY are these changes introduced?

When you run either app config link or app config use inside an app subfolder, the folder used to search/create app toml is not correct.

WHAT is this pull request doing?

  • Use the commands path flag to load the app. Once it's loaded, the logic uses the app directory

How to test your changes?

  • Run shopify app config link outside the root app folder
npm run shopify app config link --path /your/app/path/extensions --reset
  • Select a different app so a new toml file is created

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/theme-code-tools
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.88% (+0% 🔼)
6049/8188
🟡 Branches
71.09% (+0.01% 🔼)
2956/4158
🟡 Functions 72.3% 1537/2126
🟡 Lines
75.21% (+0% 🔼)
5741/7633
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / link.ts
92.86% (+0.13% 🔼)
88.24% (-1.13% 🔻)
100%
92.73% (+0.13% 🔼)
🟢
... / payload.ts
100%
92.31% (-0.55% 🔻)
100% 100%

Test suite run success

1432 tests passing in 670 suites.

Report generated by 🧪jest coverage report action from 33582eb

Copy link
Contributor

@gonzaloriestra gonzaloriestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected now! 👌

packages/app/src/cli/services/app/config/link.ts Outdated Show resolved Hide resolved
packages/app/src/cli/services/app/config/link.ts Outdated Show resolved Hide resolved
@alvaro-shopify alvaro-shopify added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit 97faa01 Sep 22, 2023
1 check passed
@alvaro-shopify alvaro-shopify deleted the fix-run-config-commands-outside-root-folder branch September 22, 2023 14:45
@shopify-shipit shopify-shipit bot temporarily deployed to nightly September 23, 2023 09:26 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production October 19, 2023 13:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants