[cli-kit] update incorrect vars in getCIMetadata #2878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
vincentezw
force-pushed
the
vez/cli-kit-getcimetadata-vars
branch
from
30b9d56
to
d6b02af
Compare
Coverage report
Test suite run success1432 tests passing in 670 suites. Report generated by 🧪jest coverage report action from d6b02af |
vincentezw
requested review from
a team,
isaacroldan and
alvaro-shopify
and removed request for
a team
isaacroldan
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Running the Hydrogen CLI in various CI platforms, we noticed some incorrect metadata, caused by non-existent or incorrect environment variables referenced in
getCIMetadata. This PR corrects. those.WHAT is this pull request doing?
Update references to environment variables present in Bitbucket and Gitlab in the
getCIMetadatafunction.How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.