Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont rename graphql on generate for functions #2882

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

nickwesselman
Copy link
Contributor

WHY are these changes introduced?

New templates being released for functions will include .graphql files under src. Without this change, the CLI will attempt to rename them.

WHAT is this pull request doing?

Excludes src/*.graphql from the rename operation for functions.

How to test your changes?

Unit test, and on a local app against the new templates.

pnpm shopify app generate extension --path /Users/nickwesselman/src/scratch/luxury-capital-app --clone-url https://github.com/Shopify/function-examples#template-updates-2023-10 --template product_discounts --name another-discount-ts

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@nickwesselman nickwesselman changed the base branch from main to stable/3.49 September 25, 2023 20:12
@nickwesselman nickwesselman changed the title Dont rename graphql on generate Dont rename graphql on generate for functions Sep 25, 2023
Copy link
Contributor

@alvaro-shopify alvaro-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 and working as expected 👍

@nickwesselman nickwesselman merged commit efda6d5 into stable/3.49 Sep 26, 2023
1 check passed
@nickwesselman nickwesselman deleted the dont-rename-graphql-on-generate branch September 26, 2023 12:27
@shopify-shipit shopify-shipit bot temporarily deployed to stable_3_49 September 29, 2023 09:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants