-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate schema from targets if present #2899
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1434 tests passing in 672 suites. Report generated by 🧪jest coverage report action from 7a14e9a |
1dd98f4
to
7428a16
Compare
7428a16
to
7a14e9a
Compare
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
I don't think I need a changeset for this because it's a bug fix for existing functionality. |
We need this fix on 3.49 as well. Looks like @andrewhassan will be out today so I'll open another one. |
WHY are these changes introduced?
With target support, the
generate schema
command for functions no longer works.Related issue: https://github.com/Shopify/script-service/issues/7327
WHAT is this pull request doing?
This PR uses a new GraphQL field to fetch the schema definition by target. The CLI uses the first target defined in a function to fetch the schema.
How to test your changes?
generate schema
in the function directoryMeasuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.