Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Running the
dev
command with the flagcheckout-cart-url
is not working with checkout ui extensions generated from the new template. The product shown when you visit the checkout extension preview url is different to the one you set in the flagThere are some issues to
dev
checkout ui extensions in spin because an error is returned from the admin api when the product variant is fetched. Using the flag is not working as workaroundWHAT is this pull request doing?
checkout_ui_extension
type it returnedundefined
as the cart url, so the flag value is lost. New checkout ui extensions have the genericui-extension
type, so we should filter them using the methodshouldFetchCartUrl
which applies to the old and new checkout ui extensionsHow to test your changes?
Test 1
dev
command with one product variantTest 2
dev
command without the flagPost-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.