Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Manage app permission to the organization not found error banner #2953

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

alvaro-shopify
Copy link
Contributor

WHY are these changes introduced?

When a user authenticates using an staff account that does not include Manage app permission an error banner is displayed with some try with suggestions. However none of them references the problem with the permission.

WHAT is this pull request doing?

  • Add a this suggestion about missing Manage app permission to the error banner
 Does your account include  Manage app  permissions?, please contact the owner of the organization to grant you access. 

How to test your changes?

  • Run the dev command
  • Authenticate using a staff account without Manage app permissions
  • Output
╭─ error ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                                        │
│  No Organization found                                                                                                                 │
│                                                                                                                                        │
│  Next steps                                                                                                                            │
│    • Have you created a Shopify Partners organization?                                                                                 │
│    • Does your account include Manage app permissions?, please contact the owner of the organization to grant you access.              │
│    • Have you confirmed your accounts from the emails you received?                                                                    │
│    • Need to connect to a different App or organization? Run the command again with `--reset`                                          │
│                                                                                                                                        │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/theme-code-tools
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.98% (+0.01% 🔼)
6086/8227
🟡 Branches
71.2% (+0.02% 🔼)
2977/4181
🟡 Functions 72.51% 1548/2135
🟡 Lines
75.29% (+0.01% 🔼)
5776/7672

Test suite run success

1447 tests passing in 673 suites.

Report generated by 🧪jest coverage report action from 1087f2b

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit d668d8b Oct 11, 2023
1 check passed
@gonzaloriestra gonzaloriestra deleted the add-missing-manage-app-message branch October 11, 2023 07:32
@shopify-shipit shopify-shipit bot temporarily deployed to experimental October 16, 2023 14:05 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to nightly October 16, 2023 17:10 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production October 19, 2023 13:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants