-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] node/git isClean to match returned type #3022
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks! Fortunately, it wasn't being used in the repository... Could you fix the tests?
Coverage report
Show files with reduced coverage 🔻
Test suite run success1452 tests passing in 675 suites. Report generated by 🧪jest coverage report action from 7dfb7c3 |
👋🏼 @gonzaloriestra I think these test updates are ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👌
WHY are these changes introduced?
While using git
isClean
I noticed the return typePromise<boolean>
did not match the actual return of the function.simple-git's
git.status().isClean
is a function and not a property.How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.