-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ruby bundler config when app is of rails type and uses bundler local config #3024
Fix ruby bundler config when app is of rails type and uses bundler local config #3024
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success1452 tests passing in 675 suites. Report generated by 🧪jest coverage report action from 28e6290 |
e0a82b2
to
a5af09a
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1,2 @@
-export declare const CLI_KIT_VERSION = "3.50.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.50.0";
+export declare const getCliKitVersion: () => string;
\ No newline at end of file
|
a5af09a
to
28e6290
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good fix, LGTM 🙏
WHY are these changes introduced?
Fixes https://github.com/Shopify/develop-app-management/issues/1517
WHAT is this pull request doing?
inTemporaryDirectory
was mockedHow to test your changes?
package.json
to use the cli version0.0.0-experimental-20231027101204
cli
processserver
processTested on Windows and Ubuntu
npm init @shopify/app@0.0.0-experimental-20231027101204 -- --template ruby
npm run shopify app generate extension -- --template theme_app_extension
npm run dev
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.