Add delivery options reducer function specification #3051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show files with reduced coverage 🔻
Test suite run success1452 tests passing in 675 suites. Report generated by 🧪jest coverage report action from 0a83859 |
stevenpslade
approved these changes
Nov 1, 2023
KevenLYF
approved these changes
Nov 6, 2023
isaacroldan
reviewed
Nov 16, 2023
| @@ -73,6 +73,7 @@ const spec = createExtensionSpecification({ | |||
| 'fulfillment_constraints', | |||
| 'order_routing_location_rule', | |||
| 'local_pickup_delivery_option_generator', | |||
| 'delivery_options_reducer', | |||
There was a problem hiding this comment.
This list is a legacy list for extensions that had in the toml: type: {the_api_type} like `type: ´fulfillment_constraints``
If this is a new api type, all new functions using this will have type: function right? so this shouldn't be necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We're introducing a new function API type which we need to deploy via
cli.WHAT is this pull request doing?
Adds the ability to deploy
delivery_options_reducerfunctions viacli.How to test your changes?
Checkout this branch locally and run the following command to deploy to a spin instance.
Post-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.