Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Company and Company Contact reference type to flow action/trigger fields serialization #3062

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

sle-c
Copy link
Contributor

@sle-c sle-c commented Nov 2, 2023

WHY are these changes introduced?

WHAT is this pull request doing?

  • Adds support for Company and Company Contact references

How to test your changes?

  • Manual test and automated tests

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.27% (-0.01% 🔻)
6251/8532
🟡 Branches 70.37% 3061/4350
🟡 Functions
71.8% (-0.05% 🔻)
1591/2216
🟡 Lines
74.44% (-0.02% 🔻)
5931/7968
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / string.ts
82.98% (-1.8% 🔻)
80.95%
68.42% (-3.8% 🔻)
83.33% (-2.03% 🔻)
🟢
... / metadata.ts
97.73% (-0.05% 🔻)
92.31% 100%
97.73% (-0.05% 🔻)
🟡
... / ruby.ts
71.43% (-0.25% 🔻)
73.13%
65.71% (-0.95% 🔻)
73.27% (-0.26% 🔻)

Test suite run success

1460 tests passing in 677 suites.

Report generated by 🧪jest coverage report action from aaaaa71

@sle-c sle-c marked this pull request as ready for review November 2, 2023 18:16

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/string.d.ts
@@ -96,4 +96,12 @@ export declare function formatDate(date: Date): string;
  * @param items - List of items.
  * @returns The joined string.
  */
-export declare function joinWithAnd(items: string[]): string;
\ No newline at end of file
+export declare function joinWithAnd(items: string[]): string;
+/**
+ * Given a string, it returns the PascalCase form of it.
+ * Eg: "pascal_case" returns "PascalCase".
+ *
+ * @param str - String to PascalCase.
+ * @returns String with all the first letter capitalized with no spaces.
+ */
+export declare function pascalize(str: string): string;
\ No newline at end of file

@sle-c
Copy link
Contributor Author

sle-c commented Nov 7, 2023

/shipit

@sle-c sle-c enabled auto-merge November 7, 2023 15:56
@sle-c sle-c added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 3afca01 Nov 7, 2023
@sle-c sle-c deleted the omnisyle/add-company-reference branch November 7, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants