-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Redirect to customer account url with target and source #3077
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/string.d.ts@@ -96,12 +96,4 @@ export declare function formatDate(date: Date): string;
* @param items - List of items.
* @returns The joined string.
*/
-export declare function joinWithAnd(items: string[]): string;
-/**
- * Given a string, it returns the PascalCase form of it.
- * Eg: "pascal_case" returns "PascalCase".
- *
- * @param str - String to PascalCase.
- * @returns String with all the first letter capitalized with no spaces.
- */
-export declare function pascalize(str: string): string;
\ No newline at end of file
+export declare function joinWithAnd(items: string[]): string;
\ No newline at end of file
|
Coverage report
Test suite run success1432 tests passing in 664 suites. Report generated by 🧪jest coverage report action from f7e8409 |
411c41b
to
6f143f1
Compare
This comment has been minimized.
This comment has been minimized.
6f143f1
to
f7e8409
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't test it, but LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 ✅
LGTM!
One question - are we going to be able to get this into a patch release (e.g. 3.50.1) in advance of Dev Preview? I don't think it's a blocker, but it would be great to have in place for that.
@jrrafols we'll release a new version next Monday, is that enough? |
By next Monday, do you mean Nov 13? If so, that would be perfect! |
We're actually planning our release on Monday, any chance we could release the new version on Friday? |
@kirakik Monday before North America wakes up is ok? |
Sure, that would work great! Thank you! |
WHY are these changes introduced?
Resolves: https://github.com/Shopify/core-issues/issues/62811
Context: when clicking the target link in cli console, you will be redirect to corresponding page in customer account web.
WHAT is this pull request doing?
Redirect to customer account url with
target
name andsource
How to test your changes?
🎩 could be seen on this pr: https://github.com/Shopify/customer-account-web/pull/3353
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.