Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Redirect to customer account url with target and source #3077

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

lihaokx
Copy link
Contributor

@lihaokx lihaokx commented Nov 8, 2023

WHY are these changes introduced?

Resolves: https://github.com/Shopify/core-issues/issues/62811

Context: when clicking the target link in cli console, you will be redirect to corresponding page in customer account web.

WHAT is this pull request doing?

Redirect to customer account url with target name and source

How to test your changes?

🎩 could be seen on this pr: https://github.com/Shopify/customer-account-web/pull/3353

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@lihaokx lihaokx changed the base branch from main to revert-3045-rainbow-bar-for-dev-launch November 8, 2023 00:10
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/string.d.ts
@@ -96,12 +96,4 @@ export declare function formatDate(date: Date): string;
  * @param items - List of items.
  * @returns The joined string.
  */
-export declare function joinWithAnd(items: string[]): string;
-/**
- * Given a string, it returns the PascalCase form of it.
- * Eg: "pascal_case" returns "PascalCase".
- *
- * @param str - String to PascalCase.
- * @returns String with all the first letter capitalized with no spaces.
- */
-export declare function pascalize(str: string): string;
\ No newline at end of file
+export declare function joinWithAnd(items: string[]): string;
\ No newline at end of file

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.86% (+0.02% 🔼)
6111/8387
🟡 Branches
70.02% (+0.04% 🔼)
2971/4243
🟡 Functions 71.48% 1564/2188
🟡 Lines
74.07% (+0.02% 🔼)
5803/7835

Test suite run success

1432 tests passing in 664 suites.

Report generated by 🧪jest coverage report action from f7e8409

@lihaokx lihaokx self-assigned this Nov 8, 2023
@lihaokx lihaokx force-pushed the redirect-to-customer-account-target branch from 411c41b to 6f143f1 Compare November 8, 2023 04:00
@lihaokx lihaokx changed the base branch from revert-3045-rainbow-bar-for-dev-launch to main November 8, 2023 04:00
@lihaokx lihaokx changed the title Redirect to customer account url with target and source Fix: Redirect to customer account url with target and source Nov 8, 2023
@lihaokx lihaokx marked this pull request as ready for review November 8, 2023 04:37

This comment has been minimized.

@lihaokx lihaokx force-pushed the redirect-to-customer-account-target branch from 6f143f1 to f7e8409 Compare November 8, 2023 05:03
Copy link
Contributor

@gonzaloriestra gonzaloriestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't test it, but LGTM!

Copy link
Contributor

@jrrafols jrrafols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 ✅
LGTM!

One question - are we going to be able to get this into a patch release (e.g. 3.50.1) in advance of Dev Preview? I don't think it's a blocker, but it would be great to have in place for that.

@gonzaloriestra
Copy link
Contributor

@jrrafols we'll release a new version next Monday, is that enough?

@jrrafols
Copy link
Contributor

jrrafols commented Nov 8, 2023

@jrrafols we'll release a new version next Monday, is that enough?

By next Monday, do you mean Nov 13? If so, that would be perfect!

@kirakik
Copy link

kirakik commented Nov 8, 2023

@jrrafols we'll release a new version next Monday, is that enough?

By next Monday, do you mean Nov 13? If so, that would be perfect!

We're actually planning our release on Monday, any chance we could release the new version on Friday?

@gonzaloriestra
Copy link
Contributor

@kirakik Monday before North America wakes up is ok?

@kirakik
Copy link

kirakik commented Nov 8, 2023

@kirakik Monday before North America wakes up is ok?

Sure, that would work great! Thank you!

@lihaokx lihaokx added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit ef80261 Nov 8, 2023
@lihaokx lihaokx deleted the redirect-to-customer-account-target branch November 8, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants