Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip - update CLI privacy #3079

Closed
wants to merge 1 commit into from
Closed

wip - update CLI privacy #3079

wants to merge 1 commit into from

Conversation

h74zhou
Copy link
Contributor

@h74zhou h74zhou commented Nov 8, 2023

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@h74zhou h74zhou changed the title update CLI privacy wip wip - update CLI privacy Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.28% (+0.43% 🔼)
6253/8533
🟡 Branches
70.37% (+0.41% 🔼)
3061/4350
🟡 Functions
71.84% (+0.32% 🔼)
1592/2216
🟡 Lines
74.45% (+0.39% 🔼)
5933/7969
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / set_beta_flag.ts
100% 100% 100% 100%
🟢
... / identifiers-functions.ts
95.45% 71.43% 100% 100%
🟢
... / mode.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / deploy.ts
86.59% (+0.47% 🔼)
92.11% (-0.75% 🔻)
78.95% (-8.55% 🔻)
88.31% (+0.08% 🔼)
🔴
... / dev.ts
13.64% (-0.51% 🔻)
1.67% (-0.12% 🔻)
13.89% (-0.82% 🔻)
13% (-0.54% 🔻)
🟢
... / versions-list.ts
100%
80% (-4.62% 🔻)
100% 100%
🟢
... / identifiers-extensions.ts
90.77% (-0.9% 🔻)
83.78% (+1.64% 🔼)
100%
91.23% (-1.22% 🔻)
🟢
... / utilities.ts
97.37% (-0.19% 🔻)
100% 80%
97.37% (-0.19% 🔻)
🟡
... / common.ts
55.17% (-1.97% 🔻)
40% (-10% 🔻)
50%
66.67% (-2.9% 🔻)
🟡
... / ruby.ts
71.68%
73.13% (-0.71% 🔻)
66.67% 73.53%

Test suite run success

1459 tests passing in 677 suites.

Report generated by 🧪jest coverage report action from 9d086b4

@h74zhou h74zhou closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant