WIP - WMP x CMP prototype #3080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Coverage report
Test suite run success1429 tests passing in 663 suites. Report generated by 🧪jest coverage report action from 5c7e285 |
isaacroldan
reviewed
Nov 13, 2023
| analytics: zod.boolean().optional(), | ||
| preferences: zod.boolean().optional(), | ||
| marketing: zod.boolean().optional(), | ||
| sale_of_data: zod.string().optional(), |
There was a problem hiding this comment.
sale_of_data: zod.enum(['sells_data', 'do_not_sell_data', 'supports_ldu_downgrade']).optiona()This will ensure only those values are accepted, no need to do any extra validation
isaacroldan
reviewed
Nov 13, 2023
| @@ -1 +0,0 @@ | |||
| (env/prepend-to-pathlist "PATH" (expand-path "./bin/shadowenv/")) | |||
There was a problem hiding this comment.
careful not to remove this file or change the .gitignore above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.