Update flow template spec for allowOneClickActivate #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1495 tests passing in 670 suites. Report generated by 🧪jest coverage report action from ef3244d |
isaacroldan
approved these changes
Nov 13, 2023
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
tommybae
force-pushed
the
3099/one-click-activate-opt/tb
branch
from
4358d6e
to
791fe6a
Compare
tommybae
force-pushed
the
3099/one-click-activate-opt/tb
branch
from
791fe6a
to
ef3244d
Compare
cgidzinski
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related task: https://github.com/Shopify/flow-app/issues/3100
Marking some template extension fields as optional as we'll provide defaults if these values are not provided
WHAT is this pull request doing?
Updates some properties on the Flow template extension schema to be optional
How to test your changes?
Video
Post-release steps
None, unreleased feature to be tested with 1p later this year.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.