-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update styles for GraphiQL top bar #3093
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
f06fea0
to
362081c
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success1433 tests passing in 664 suites. Report generated by 🧪jest coverage report action from ca8c8d1 |
Do we really need mobile viewport sizes? GraphiQL really isn't designed for that environment, and I don't think we need to take it into account. |
c853539
to
31ab437
Compare
@matlegault how's this? Still too much space? Is the alignment OK? Before: After: |
@amcaplan Here if this helps! Almost there. In general I want the spacing to the left of the icon to be about the same as on the right, visually speaking. Here, the icon has some padding around the shape itself but if yours doesn't you can aim for about 8px spacing to its left and right 👍 |
f963dce
to
7986a72
Compare
7986a72
to
8a1838e
Compare
WHY are these changes introduced?
relates to: #2887 and https://github.com/Shopify/develop-app-management/issues/1494
figma: https://www.figma.com/file/1UrPp4aUxgxSmBOZeJAUkC/GraphiQL?type=design&node-id=5-15794&mode=dev
WHAT is this pull request doing?
This draft PR gets much of the way towards updating the GraphiQL style bar per @matlegault's designs.
in this PR:
font-family
rule declaration/fallbacks fromweb
not in this PR
main
is able to build properly again, rebase this PR against those fixes and everything should work properly :)=== UPDATE 2023-11-14 by @amcaplan ===
Build is working, and we made some more improvements. Here's how it looks now.
Before:
After:
How to test your changes?
Shopify/cli
locally on thisupdate-graphiql-top-bar-styles
branchpnpm shopify app dev --path ../path-to-your-app
(if you don't already have an app, you'll be prompted to create one here)dev
is running smoothly, pressg
to launch GraphiQL, you'll see the top bar :)Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.