Fix extension watcher infinite loop #3112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
I recently introduced some changes in the extensions watcher to unify them into a single one.
However, I made a last minute change: from watching only inside
src
to watching in any folder. I didn't test that properly and it obviously breaks everything because we shouldn't watch in folders likedist
ornode_modules
WHAT is this pull request doing?
src
folderHow to test your changes?
dev
in an app with different extension types and try to make changes in files inside src/dist/node_modules and also test file. Only actual source files should trigger a re-buildPost-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.