Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension watcher infinite loop #3112

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix extension watcher infinite loop #3112

merged 2 commits into from
Nov 16, 2023

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Nov 16, 2023

WHY are these changes introduced?

I recently introduced some changes in the extensions watcher to unify them into a single one.

However, I made a last minute change: from watching only inside src to watching in any folder. I didn't test that properly and it obviously breaks everything because we shouldn't watch in folders like dist or node_modules

WHAT is this pull request doing?

  • Only watch for files inside the src folder
  • Ignore test files (we don't need to upload a new draft if you change the tests)

How to test your changes?

  • run dev in an app with different extension types and try to make changes in files inside src/dist/node_modules and also test file. Only actual source files should trigger a re-build

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.88% (-0.01% 🔻)
6153/8443
🟡 Branches
70.11% (-0.02% 🔻)
2970/4236
🟡 Functions 71.82% 1570/2186
🟡 Lines
74.01% (-0.01% 🔻)
5843/7895
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
97.62% (-2.38% 🔻)
75% (-8.33% 🔻)
100%
97.44% (-2.56% 🔻)

Test suite run success

1434 tests passing in 664 suites.

Report generated by 🧪jest coverage report action from 9e6cbd9

Copy link
Contributor

@Arkham Arkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isaacroldan isaacroldan added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit 82c4043 Nov 16, 2023
@isaacroldan isaacroldan deleted the fix-watcher branch November 16, 2023 14:03
@dmerand dmerand added the #gsd:36798 Consistent dev project. https://vault.shopify.io/gsd/projects/36798 label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:36798 Consistent dev project. https://vault.shopify.io/gsd/projects/36798
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants