Use correct env variable #3131
Merged
Use correct env variable #3131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcaplan
force-pushed
the
correct-env-var
branch
from
6a21750
to
e3690b4
Compare
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
alvaro-shopify
approved these changes
Nov 22, 2023
BUNDLE_APP_CONFIG sets the expected location of a configuration file. BUNDLE_PATH sets the location for the cache.
amcaplan
force-pushed
the
correct-env-var
branch
from
e3690b4
to
4ea4c08
Compare
Coverage report
Test suite run success1495 tests passing in 670 suites. Report generated by 🧪jest coverage report action from 4ea4c08 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #3102
Fixes #3125
WHAT is this pull request doing?
BUNDLE_APP_CONFIGsets the expected location of a configuration file.BUNDLE_PATHsets the location for the cache. The explanation is pretty clear here, and I confirmed on a Linux VM.How to test your changes?
Install ruby and node on Linux using raw
apt-get, and see this fail when runningtheme-check. On this branch, you don't see the same failure.Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.