Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 14 support #3164

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Drop Node 14 support #3164

merged 1 commit into from
Dec 4, 2023

Conversation

amcaplan
Copy link
Contributor

@amcaplan amcaplan commented Dec 3, 2023

WHY are these changes introduced?

Node 14 has long been EoL. We now warn if it's used, our docs say you need 18+, and in practice it's now used by < 0.5% of users on a recent CLI version.

Time for Node 14 to go!

WHAT is this pull request doing?

Specifies a requirement for Node 16+ in all package.jsons that previously stated 14 was ok.

How to test your changes?

N/A

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

github-actions bot commented Dec 3, 2023

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

Copy link
Contributor

github-actions bot commented Dec 3, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.08% (-0.01% 🔻)
6256/8561
🟡 Branches
70.71% (-0.02% 🔻)
3044/4305
🟡 Functions 71.75% 1585/2209
🟡 Lines
74.22% (-0.01% 🔻)
5941/8005
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
97.62% (-2.38% 🔻)
75% (-8.33% 🔻)
100%
97.44% (-2.56% 🔻)

Test suite run success

1494 tests passing in 670 suites.

Report generated by 🧪jest coverage report action from 5a17889

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit 6bbbe66 Dec 4, 2023
@gonzaloriestra gonzaloriestra deleted the kill-node-14 branch December 4, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants