Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the experience property nstead of relying on the management_exp… #3178

Closed

Conversation

AniTumany
Copy link
Contributor

…erience

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/object.d.ts
@@ -45,4 +45,21 @@ export declare function deepCompare(one: object, two: object): boolean;
  * @param two - The second object to be compared.
  * @returns Two objects containing the fields that are different, each one with the values of one object.
  */
-export declare function deepDifference(one: object, two: object): [object, object];
\ No newline at end of file
+export declare function deepDifference(one: object, two: object): [object, object];
+/**
+ * Gets the value at path of object. If the resolved value is undefined, the defaultValue is returned in its place.
+ *
+ * @param object - The object to query.
+ * @param path - The path of the property to get.
+ * @returns - Returns the resolved value.
+ */
+export declare function getPathValue<T = object>(object: object, path: string): T | undefined;
+/**
+ * Sets the value at path of object. If a portion of path doesn't exist, it's create.
+ *
+ * @param object - The object to modify.
+ * @param path - The path of the property to set.
+ * @param value - The value to set.
+ * @returns - Returns object.
+ */
+export declare function setPathValue(object: object, path: string, value: object): object;
\ No newline at end of file
packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.52.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.51.0";
\ No newline at end of file

@@ -218,7 +218,7 @@ async function resolveRemoteExtensionIdentifiersBreakdown(

const appModuleVersionsNonConfig =
activeAppVersion.app.activeAppVersion?.appModuleVersions.filter(
(module) => module.specification !== null && module.specification?.options.managementExperience !== 'app_config',
(module) => module.specification !== null && module.specification?.experience !== 'configuration',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could simplify the logic in this file. It seems to me that we do compare local extensions/configurations against the module versions included in the active app version. It might be helpful to create a diagram like this one to show what exactly we are comparing against what. That we can see if there's a way to simplify this further.

cc @alvaro-shopify

@pt2pham
Copy link
Contributor

pt2pham commented Jan 5, 2024

Closing this as we've shipped these changes into Core already

@pt2pham pt2pham closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants