Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble up failure from developerPreviewUpdate #3181

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Conversation

amcaplan
Copy link
Contributor

@amcaplan amcaplan commented Dec 7, 2023

WHY are these changes introduced?

Fixes #3173

WHAT is this pull request doing?

We aren't actually refreshing the token in the background during dev, because the error wasn't bubbling up and we have a mechanism to only refresh on error:

} catch (_err) {
try {
await refreshToken()

We seem to use these functions in a limited number of other places, but I don't see anywhere they shouldn't cause a failure.

How to test your changes?

Run dev overnight on an app with UI extensions. You should never see a complaint that dev preview mode isn't being updated.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.02% (+0.01% 🔼)
6253/8563
🟡 Branches
70.54% (-0.02% 🔻)
3038/4307
🟡 Functions
71.75% (+0.01% 🔼)
1585/2209
🟡 Lines
74.18% (+0.01% 🔼)
5937/8003
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
97.62% (-2.38% 🔻)
75% (-8.33% 🔻)
100%
97.44% (-2.56% 🔻)

Test suite run success

1483 tests passing in 669 suites.

Report generated by 🧪jest coverage report action from cc3ada0

This will allow the refreshToken mechanism to be triggered
@amcaplan amcaplan added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit 1e79fe5 Dec 11, 2023
@amcaplan amcaplan deleted the refresh-auth-token-in-dev branch December 11, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: shopify app dev stops authenticating development store preview
2 participants