Increase required minimum version to Node 18 #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcaplan
force-pushed
the
kill-node-16
branch
from
fd804ac
to
5682640
Compare
Coverage report
Test suite run success1483 tests passing in 669 suites. Report generated by 🧪jest coverage report action from 1d6fe34 |
amcaplan
force-pushed
the
kill-node-16
branch
from
139cf7a
to
8bdd4e3
Compare
amcaplan
force-pushed
the
kill-node-16
branch
2 times, most recently
from
db8d229
to
5bda227
Compare
amcaplan
force-pushed
the
kill-node-16
branch
from
5bda227
to
1d6fe34
Compare
gonzaloriestra
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Docs say we require Node.js 18 or higher. But it's actually 18.12 or higher, should we update it to be more accurate? cc: @shainaraskas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Drops support for Node 16, which will allow us to:
NOTES:
WHAT is this pull request doing?
Updates:
enginesfield inpackage.jsons@types/nodeto look for Node 18I didn't touch any
ui-extensions-*packages, as those generally work differently and I'm not as certain what's needed.How to test your changes?
Things should continue to work, generally speaking.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.