Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update admin api_access config #3248

Closed
wants to merge 3 commits into from
Closed

Conversation

billfienberg
Copy link
Contributor

@billfienberg billfienberg commented Jan 11, 2024

WHY are these changes introduced?

TLDR: Update admin's api_access config to match aligned API from RFC.

These changes are relevant for the Versioned App Config project, and the Versioned App Config project is a prerequisite for the Direct API project.

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@billfienberg billfienberg changed the title chore: add failing loader tests for capabilities.api_access.admin Update admin api_access config Jan 11, 2024
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 73.67% 6493/8814
🟡 Branches 70.93% 3167/4465
🟡 Functions 72.8% 1662/2283
🟡 Lines 74.79% 6143/8214

Test suite run success

1528 tests passing in 701 suites.

Report generated by 🧪jest coverage report action from 867619d

@billfienberg
Copy link
Contributor Author

Closing in lieu of #3258

@billfienberg billfienberg deleted the update-api-access-mode branch January 29, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant