Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate privacy compliance webhooks config specification #3291

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

alvaro-shopify
Copy link
Contributor

@alvaro-shopify alvaro-shopify commented Jan 23, 2024

WHY are these changes introduced?

Depends-on: https://github.com/Shopify/shopify/pull/476655

WHAT is this pull request doing?

  • Integrate the new configuration app module privacy compliance webhooks

How to test your changes?

  • Create a new cli app and run the p shopify app config link --path /PATH/TO/YOUR/APP command to link it to a new remote app.
  • Enable versioned_app_config beta flag in the created app.
  • Modify the toml to include some content for the privacy compliance
  [webhooks.privacy_compliance]
  customer_deletion_url = "https://customer-deletion-url.dev"
  customer_data_request_url = "https://customer-data-request-url.dev"
  shop_deletion_url = "https://shop-deletion-url.dev"
  • Run p shopify app deploy --path /PATH/TO/YOUR/APP and confirm
  • Modify some privacy compliance values and run p shopify app config link --path /PATH/TO/YOUR/APP to restore the pushed values

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.77% (+0.03% 🔼)
6588/8930
🟡 Branches
70.82% (+0.04% 🔼)
3196/4513
🟡 Functions
73.29% (+0.04% 🔼)
1726/2355
🟡 Lines
74.87% (+0.03% 🔼)
6222/8310
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / app_config_privacy_compliance_webhooks.ts
100% 100% 100% 100%

Test suite run success

1558 tests passing in 734 suites.

Report generated by 🧪jest coverage report action from 70da346

@alvaro-shopify alvaro-shopify merged commit 171e239 into main Jan 25, 2024
@alvaro-shopify alvaro-shopify deleted the integrate-privacy-compliance branch January 25, 2024 10:47
@pt2pham pt2pham added the #gsd:36684 Versioned app configurations project (https://vault.shopify.io/gsd/projects/36684) label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:36684 Versioned app configurations project (https://vault.shopify.io/gsd/projects/36684)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants