Specify package manager default by ENV var not flag #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, oclif treated --flag=a --flag=b as the second overriding the first. Now, though, oclif treats that as an invalid condition. So we use an ENV var to specify the npm default instead, and users can override by passing `--package-manager=yarn` as we do in `bin/create-test-app.js`.
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success1556 tests passing in 730 suites. Report generated by 🧪jest coverage report action from ad9739f |
isaacroldan
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Previously, oclif treated
--flag=a --flag=bas the second overriding the first. In v3, though, oclif treats that as an invalid condition.We use this double-specification in
bin/create-test-app.js, where the default is--package-manager=npmbut we override with--package-manager=yarn. Hence:WHAT is this pull request doing?
Use an ENV var to specify the npm default instead.
How to test your changes?
node bin/create-test-app.js -p yarnshould work without seeing a failure.Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.