-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Themes] Fix Theme Push Execution when password flag is provided #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Coverage report
Show files with reduced coverage 🔻
Test suite run success1617 tests passing in 754 suites. Report generated by 🧪jest coverage report action from 59ee23f |
jamesmengo
force-pushed
the
jmeng/fix_push_in_ci
branch
3 times, most recently
from
April 2, 2024 22:46
03b5109
to
8f29af4
Compare
jamesmengo
force-pushed
the
jmeng/fix_push_in_ci
branch
3 times, most recently
from
April 3, 2024 16:04
c862467
to
8667f88
Compare
karreiro
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jamesmengo! LGTM and works as expected as well 🎩 I've left only one minor/optional suggestion :)
Thanks for fixing this so quickly!
jamesmengo
force-pushed
the
jmeng/fix_push_in_ci
branch
from
April 3, 2024 16:31
8667f88
to
59ee23f
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
WHAT is this pull request doing?
push command
when thepassword
flag is providedpush command
and any CI consumers without needing to explicitly provide the--stable
flagHow to test your changes?
Main
pnpm shopify theme push --password <PASSWORD>
The first execution should have resulted in an empty theme being pushed
The second execution should result in the files being uploaded properly
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.