Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when you deploy an empty array of redirect_urls #3667

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

alvaro-shopify
Copy link
Contributor

WHY are these changes introduced?

Related #3479

Once you deploy an app using an empty array of redirect_url then the commands link and deploy --reset don't work anymore

WHAT is this pull request doing?

  • The method that writes the configuration object into the toml doesn't remove empty array entries

How to test your changes?

  • deploy an app using redirect_urls = []
  • Run link or deploy --reset and the command should succeed

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.16% 6829/9464
🟡 Branches
69.21% (+0.01% 🔼)
3342/4829
🟡 Functions 70.99% 1823/2568
🟡 Lines 73.3% 6439/8784

Test suite run success

1627 tests passing in 755 suites.

Report generated by 🧪jest coverage report action from f5ebcf5

Copy link
Contributor

@amcaplan amcaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@alvaro-shopify alvaro-shopify added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit c3f8c9f Apr 9, 2024
@alvaro-shopify alvaro-shopify deleted the fix-link-properties-with-empty-arrays branch April 9, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants