Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/3.59] Fix app analytics #3836

Merged
merged 4 commits into from
May 2, 2024
Merged

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

We the introduction of bundling, we need to explicitly export all Hooks, we were missing some hooks from the app package.

This was causing some important metadata to not be tracked.

WHAT is this pull request doing?

  • Export app hooks from app
  • Re-export app hooks from cli
  • Update CLI package.json to link to the exported hooks

How to test your changes?

Running a command like shopify app info --verbose should show different metadata payload in main vs this branch. This branch includes the "sensitive" part of app (like the name)

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@isaacroldan isaacroldan changed the base branch from main to stable/3.59 May 2, 2024 14:48
@isaacroldan isaacroldan merged commit 230acc7 into stable/3.59 May 2, 2024
@isaacroldan isaacroldan deleted the fix-app-analytics-stable branch May 2, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants